PDFedit Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000285 [GUI] =Other (GUI)= tweak always 02-12-09 02:14 02-26-09 21:53
Reporter Alister View Status public  
Assigned To hockm0bm
Priority normal Resolution fixed  
Status resolved  
Summary 0000285: Request: insert pages gui - insert after last page
Description Using the gui to insert pages, if you want to insert pages at the end of the document, you have to insert them before the last page, and then move the last page up past them all.
Wouldn't it be reasonably straightforward for there to be a fake "page" in the list of pages - called [END] or something, that we could click on to actually insert pages at the end?
Additional Information
Attached Files  mergeform-fake_end_page.patch [^] (2,980 bytes) 02-12-09 13:32

- Relationships

- Notes
(0000657)
hockm0bm
02-12-09 13:31

I don't consider it as a problem because moving up/down is not performance critical and it is consistent - you always insert before selected page.

Adding "fake" page is kind of hack and I am not sure I like that idea.

Nevertheless, implementation is really simple, so the patch will follow, so you can use it and compile your own version if you like. I will suggest that patch on our devel mailing list and if others vote for it we will integrate it also into our repository
 
(0000658)
hockm0bm
02-12-09 13:32

Martin what do you think about patch?
 
(0000659)
hockm0bm
02-12-09 13:33

Alister, let me know if you need some help or how do you like the solution (please not that the final solution would also require translations of the string)
 
(0000661)
Alister
02-12-09 23:12

I like the solution :)

Sorry though - I didn't describe the problem very accurately.
It is not possible to click on the last page of the original document and click up - you actually have to click on the last page you inserted, click down, click on the second to last page you inserted, click down, etc. This would be very tiresome if you inserted a lot of pages.
If you knew what you were doing you would insert the last page that you want to add, move it to the bottom, then insert the other pages before it. But that is not very user-friendly.

It might be kind of a hack, but it is simple, and would be a big improvement for people that use pdfedit mainly for assembling documents - inserting, rotating and deleting pages - which is what people I know mostly use pdfedit for.

There is potential for a lot more improvement in terms of document assembly and dealing with pages:
- the ability to use the up and down buttons in the on pages in the original document
- a pane with page thumbnails
- page previews e.g. in the insert pages dialog
- the ability to drag and drop pages to move them around in the document (in the tree and/or thumbnail pane and/or insert pages dialog)
- a function to replace a page with page(s) from another document (Maybe this could be done with a user script - although I think it would need a new dialog).
- etc.

I imagine most of these things would take a lot of work, but it might be possible to turn the insert pages dialog into a more generic "page manager", by allowing:
- up/down buttons for pages in the original document, instead of just for the added pages.
- multiple selection in the left pane (with Ctrl-Click/Shift-Click)
- remove pages from the original document.

Anyway, these things would all take work so I'd be delighted just to see your patch included :)
 
(0000663)
hockm0bm
02-13-09 14:01

> I like the solution :)

> Sorry though - I didn't describe the problem very accurately.
> It is not possible to click on the last page of the original document and
> click up - you actually have to click on the last page you inserted, click
> down, click on the second to last page you inserted, click down, etc. This
> would be very tiresome if you inserted a lot of pages.

I am not sure I understand what you are trying to tell. Original pages are not movable by design. The page insert dialog was meant to be as simple as possible.
If we would enable also original pages moving then we would have more complicated logic behind pages merging.
  
>
> If you knew what you were doing you would insert the last page that you want
> to add, move it to the bottom, then insert the other pages before it. But
> that is not very user-friendly.

Why don't u use multiselect in the opened document and insert them together? Note that all of them will be inserted before the currently selected one (e.g. in case of [END] all of them would be inserted after all pages from the original document).

>
> It might be kind of a hack, but it is simple, and would be a big improvement
> for people that use pdfedit mainly for assembling documents - inserting,
> rotating and deleting pages - which is what people I know mostly use pdfedit
> for.

look at the page.qs file which contains page manipulation scripts. Maybe they could help with your tasks. Nevertheless I do believe that gui wrappers would be much much better.

>
> There is potential for a lot more improvement in terms of document assembly
> and dealing with pages:

agreed

> - the ability to use the up and down buttons in the on pages in the original
> document

I would rather go for separate dialog for this.

> - a pane with page thumbnails
> - page previews e.g. in the insert pages dialog

Nice but I am not sure how useful wrt. efforts.

> - the ability to drag and drop pages to move them around in the document (in
> the tree and/or thumbnail pane and/or insert pages dialog)

too much effort and I am afraid that our gui infrastructure[*] is not prepared for that.

> - a function to replace a page with page(s) from another document (Maybe this
> could be done with a user script - although I think it would need a new
> dialog).

simple with user script (insert & delete)

> - etc.

I could imagine ;)

>
> I imagine most of these things would take a lot of work, but it might be
> possible to turn the insert pages dialog into a more generic "page manager",
> by allowing:
> - up/down buttons for pages in the original document, instead of just for the
> added pages.
> - multiple selection in the left pane (with Ctrl-Click/Shift-Click)
> - remove pages from the original document.

I would rather keep the current functionality - it is simple and clear - and add a new dialog for page manipulation.

>
> Anyway, these things would all take work so I'd be delighted just to see your
> patch included :)

I have posted it to the pdfedit-devel mailing list, so let's see how other developers take it.



[*] Note that I am not very familiar with gui part as I was working almost exclusively on the kernel part.
 
(0000665)
Alister
02-14-09 04:44
edited on: 02-14-09 04:48

>> Sorry though - I didn't describe the problem very accurately.
>> It is not possible to click on the last page of the original document and
>> click up - you actually have to click on the last page you inserted, click
>> down, click on the second to last page you inserted, click down, etc. This
>> would be very tiresome if you inserted a lot of pages.
>
>I am not sure I understand what you are trying to tell. Original pages are not movable by design. The page insert dialog was meant to be as simple as possible.

Yes, sorry for the confusion - I was just saying that I didn't realise this when I described it originally - I had already inserted a page and moved it to the bottom before I inserted the other pages, so I was able to move the bottom page up as it wasn't from the original document.
>If we would enable also original pages moving then we would have more complicated logic behind pages merging.

I realise this :)

>> If you knew what you were doing you would insert the last page that you want
>> to add, move it to the bottom, then insert the other pages before it. But
>> that is not very user-friendly.
>
>Why don't u use multiselect in the opened document and insert them together? Note that all of them will be inserted before the currently selected one (e.g. in case of [END] all of them would be inserted after all pages from the original document).

I was just describing the best way to do it without your patch, in case someone else with the same problem saw this, and didn't want to recompile with the patch :)


>> - a function to replace a page with page(s) from another document (Maybe this
>> could be done with a user script - although I think it would need a new
>> dialog).
>
>simple with user script (insert & delete)

Would it be simple to do including a gui to choose the pages to insert? Because it would be different from the insert gui...
BTW I should have said "replace page(s) with page(s) from another document"

 
(0000666)
hockm0bm
02-16-09 09:50

> Would it be simple to do including a gui to choose the pages to insert? Because > it would be different from the insert gui...

New dialogs inserting is not very hard. Insert page dialog can be used as an example on how to do it. Apart from dialog itself it also need to be registered to be usable from gui (grep is your friend ;)).
There is also another option - since 0.4.2 PDFedit can be compiled also as development package which can be installed independently from GUI and used by any program. Then you can create a standalone application which just links to PDFedit libraries and which uses just the functionality it needs (e.g. page manipulation methods).

> BTW I should have said "replace page(s) with page(s) from another document"
 
(0000701)
hockm0bm
02-26-09 15:08

I think we can close this issue, right? If you have some ideas on how to enhance page merging, please report a feature request with your ideas.
 
(0000702)
hockm0bm
02-26-09 17:01

JFYI the patch has been committed to our CVS.
 
(0000703)
anonymous
02-26-09 21:49

Great. We can definitely close it.
 
(0000704)
hockm0bm
02-26-09 21:53

Issue is fixed and the next feature/enhancements can be reported separately.
 

- Issue History
Date Modified Username Field Change
02-12-09 02:14 Alister New Issue
02-12-09 13:31 hockm0bm Note Added: 0000657
02-12-09 13:32 hockm0bm File Added: mergeform-fake_end_page.patch
02-12-09 13:32 hockm0bm Status new => assigned
02-12-09 13:32 hockm0bm Assigned To  => bilbo
02-12-09 13:32 hockm0bm Note Added: 0000658
02-12-09 13:33 hockm0bm Note Added: 0000659
02-12-09 23:12 Alister Note Added: 0000661
02-13-09 14:01 hockm0bm Note Added: 0000663
02-14-09 04:44 Alister Note Added: 0000665
02-14-09 04:48 Alister Note Edited: 0000665
02-16-09 09:50 hockm0bm Note Added: 0000666
02-26-09 15:08 hockm0bm Note Added: 0000701
02-26-09 15:09 hockm0bm Assigned To bilbo => hockm0bm
02-26-09 17:01 hockm0bm Note Added: 0000702
02-26-09 21:49 anonymous Status assigned => closed
02-26-09 21:49 anonymous Note Added: 0000703
02-26-09 21:49 anonymous Resolution open => fixed
02-26-09 21:53 hockm0bm Status closed => resolved
02-26-09 21:53 hockm0bm Note Added: 0000704