PDFedit Bugtracker
Main | My View | View Issues | Docs
  

Viewing Issue Simple Details [ Jump to Notes ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000357 [PDFedit] Compilation minor always 06-09-10 07:13 06-09-10 22:12
Reporter leonidas666 View Status public  
Assigned To hockm0bm
Priority normal Resolution fixed  
Status resolved   Product Version
Summary 0000357: ./configure script does not complain about missing png.h
Description I did a ./configure --disable-release --disable-gui --enable-tools --enable-doxygen-doc --enable-advanced-doc --enable-pdfedit-core-dev
and a corresponding makefile was produced.
However, while compiling it complained that a "png.h" was missing. So i installed libpng-dev (i'm using ubuntu), and then i could compile.
Shouldn't the configure-script tell me that the headers for libpng are missing?
Additional Information
Attached Files  configure-check_for_png.patch [^] (4,031 bytes) 06-09-10 11:13

- Relationships

- Notes
(0001085)
hockm0bm
06-09-10 11:06

 se --disable-gui --enable-tools --enable-
> doxygen-doc --enable-advanced-doc --enable-pdfedit-core-dev
> and a corresponding makefile was produced.
>
> However, while compiling it complained that a "png.h" was missing. So i
> installed libpng-dev (i'm using ubuntu), and then i could compile.

libpng-dev is required only for tools which are not a priority wrt. the building system (as they are not distributed ATM) so this didn't show up during testing.

> Shouldn't the configure-script tell me that the headers for libpng are missing?

Yes, the patch will follow up shortly
 
(0001086)
hockm0bm
06-09-10 11:17

 Could you give a try to the attached patch (configure-check_for_png.patch). You just need to run autoconf after it is applied and then run configure again.
Finally just go to src/tools and type make.

The patch seems to be correct if both library and dev package is installed. I haven't tested the fail case. I would try it but libpng12-dev (in Debian) has many dependencies which are currently installed on my system and would like to prevent a big uninstall & install session or big chroot dances.

It seems that you might be in a better position. I guess that -dev package testing scenario is sufficient (there is no need to test libpng existence case).
 
(0001088)
leonidas666
06-09-10 22:04

 I applied the patch, then i ran autoconf.
Then i deinstalled libpng-dev, and run ./configure again.
it stoppen after the following output:

checking for png library... checking for png_check_sig in -lpng... no
checking png.h usability... no
checking png.h presence... no
checking for png.h... no
configure: error: libpng is not found

So i guess it is working as expected.
 
(0001089)
hockm0bm
06-09-10 22:10

 Yes. THis is it. Thanks for testing!
 
(0001090)
hockm0bm
06-09-10 22:12

 The patch has been committed to the CVS
 

- Issue History
Date Modified Username Field Change
06-09-10 07:13 leonidas666 New Issue
06-09-10 11:06 hockm0bm Status new => assigned
06-09-10 11:06 hockm0bm Assigned To  => hockm0bm
06-09-10 11:06 hockm0bm Note Added: 0001085
06-09-10 11:13 hockm0bm File Added: configure-check_for_png.patch
06-09-10 11:17 hockm0bm Note Added: 0001086
06-09-10 22:04 leonidas666 Note Added: 0001088
06-09-10 22:10 hockm0bm Note Added: 0001089
06-09-10 22:12 hockm0bm Status assigned => resolved
06-09-10 22:12 hockm0bm Resolution open => fixed
06-09-10 22:12 hockm0bm Note Added: 0001090