PDFedit Bugtracker
Main | My View | View Issues | Docs
  

Viewing Issue Simple Details [ Jump to Notes ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000367 [GUI] =Other (GUI)= minor always 01-20-11 18:09 01-24-11 00:13
Reporter hockm0bm View Status public  
Assigned To
Priority normal Resolution open  
Status new  
Summary 0000367: edit page metrics doesn't work correctly for rotated documents
Description If a document has rotation applied to a page, page metrics hints are not correct.

In fact the hints are not correct even if rotation is 0 we need to switch bottom and upper corners (e.g. zadani.pdf).

I have posted a patch to fix this (will attach it here as well) but even this doesn't work correctly for rotated pages because rotation is applied after page metrics.
Additional Information
Attached Files  gui-edit_page_matrics-fix-coord-desc.patch [^] (2,250 bytes) 01-20-11 18:10

- Relationships

- Notes
(0001112)
bilbo
01-23-11 11:52

 I think the patch is fine, though after rotation, the media box is still relative to original unrotated coordinates (well, the rotation works by setting one parameter of the page to a multiple of 90, which is then interpreted by viewers). I think adding extra line of text like
"The coordinates are based on bottom left corner of the page, before applying page rotation specified for the page" to the dialog may clarify the things a bit more.
 
(0001113)
hockm0bm
01-24-11 00:13

 I think that we should be more user friendly than that. Top resp. bottom should refer to what you are seeing at the moment (after rotation is applied).
I am just not sure what is the proper level where to do it. We have basically 2 options
- do it in the gui
- update the kernel interface

None of them is really hard because you have the whole information. I am more and more inclined to the second choice. CPage.setMediabox would get a new bool parameter afterRotation and if true it would rotate the given parameters according to the current Rotation. I like it more because it will make tools programming little bit easier. I will come up with a patch
 

- Issue History
Date Modified Username Field Change
01-20-11 18:09 hockm0bm New Issue
01-20-11 18:10 hockm0bm File Added: gui-edit_page_matrics-fix-coord-desc.patch
01-23-11 11:52 bilbo Note Added: 0001112
01-24-11 00:13 hockm0bm Note Added: 0001113